Messages in this thread | | | Date | Mon, 30 Dec 2013 14:19:44 +0100 | From | Sebastian Reichel <> | Subject | Re: [PATCH v2] Bluetooth: Add hci_h4p driver |
| |
Hi,
On Mon, Dec 30, 2013 at 01:13:50PM +0100, Pavel Machek wrote: > [...] > > Well, I can rename config option, but renaming the module would break > existing userland, no?
Why is the userland depending on the module name?
> > Can we also make this just depend on some device tree information > > and not on a specific architecture. I know that this driver is > > pretty much OMAP specific, but if we want this upstream, we should > > at least try to make it more generic. > > Nokia N900 is certainly moving towards device tree, but we are not > ready, yet...
Tony plans to remove OMAP3 boardcode (incl. omap3-rx51) in 3.14.
> > > [...] > > > > > Please do not introduce public includes for a driver. This > > should be all confined to the driver itself or if it platform > > data, it should go into the place for platform data. > > (Could you insert newlines after 80 or so characters?) > > Where would you like platform_data definition to go? That indeed is > for platform data, and quick grep shows drivers normally do public > header files for that.
Probably it can simply be removed, because it's not useful in 3.14?
> [...]
-- Sebastian [unhandled content-type:application/pgp-signature] | |