Messages in this thread | | | Date | Fri, 27 Dec 2013 19:57:55 +0100 | From | Francois Romieu <> | Subject | Re: [PATCH net-next 3/6] r8152: change some definitions |
| |
Hayes Wang <hayeswang@realtek.com> : [...] > diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c > index b8bc3eb..a8ea848 100644 > --- a/drivers/net/usb/r8152.c > +++ b/drivers/net/usb/r8152.c [...] > @@ -274,6 +274,9 @@ enum rtl_register_content { > #define RTL8152_MAX_TX 10 > #define RTL8152_MAX_RX 10 > #define INTBUFSIZE 2 > +#define CRC_SIZE 4
ETH_FCS_LEN ?
[...] > @@ -1215,7 +1220,7 @@ static void rx_bottom(struct r8152 *tp) > > stats = rtl8152_get_stats(netdev); > > - pkt_len -= 4; /* CRC */ > + pkt_len -= CRC_SIZE; /* CRC */ > rx_data += sizeof(struct rx_desc);
Nit: you may remove the trailing "/* CRC */" in the same patch.
-- Ueimor
| |