Messages in this thread | | | Date | Fri, 27 Dec 2013 12:28:13 -0500 (EST) | Subject | Re: [PATCH net-next 4/6] r8152: add rtl_ops | From | David Miller <> |
| |
From: Hayes Wang <hayeswang@realtek.com> Date: Fri, 27 Dec 2013 10:34:08 +0800
> > +static int rtl_ops_init(struct r8152 *tp, const struct usb_device_id *id) ... > > + if (rtl_ops_init(tp, id)) { > + netif_err(tp, probe, netdev, "Unknown Device"); > + return -ENODEV;
You're completely ignoring the error code returned from rtl_ops_init() (which, as an aside, uses -EFAULT which doesn't seem all that appropriate).
You might as well have rtl_ops_init() return a boolean.
| |