Messages in this thread Patch in this message | | | From | Prarit Bhargava <> | Subject | [PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu_disable() | Date | Mon, 23 Dec 2013 09:39:12 -0500 |
| |
Patch is against linux-tip.git and was tested on both linux.git and tip without any issues. As expected, the number of required vectors for the down'd cpu drops from 202 to 181 on my test system (which has 509 vectors assigned in total).
Many thanks to Gong Chen for catching this.
P.
----8<----
Gong Chen caught this coding error during inspection of the patch. The code should be AND not OR.
Signed-off-by: Prarit Bhargava <prarit@redhat.com> Cc: Michel Lespinasse <walken@google.com> Cc: Seiji Aguchi <seiji.aguchi@hds.com> Cc: Yang Zhang <yang.z.zhang@Intel.com> Cc: Paul Gortmaker <paul.gortmaker@windriver.com> Cc: Janet Morgan <janet.morgan@intel.com> Cc: Tony Luck <tony.luck@intel.com> Cc: Ruiv Wang <ruiv.wang@gmail.com> Cc: Gong Chen <gong.chen@linux.intel.com> Cc: Andi Kleen <ak@linux.intel.com> Cc: H. Peter Anvin <hpa@linux.intel.com> Cc: x86@kernel.org Cc: <stable@vger.kernel.org> --- arch/x86/kernel/irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c index 7d40698..aed7acc 100644 --- a/arch/x86/kernel/irq.c +++ b/arch/x86/kernel/irq.c @@ -281,7 +281,7 @@ int check_irq_vectors_for_cpu_disable(void) desc = irq_to_desc(irq); data = irq_desc_get_irq_data(desc); affinity = data->affinity; - if (irq_has_action(irq) || !irqd_is_per_cpu(data) || + if (irq_has_action(irq) && !irqd_is_per_cpu(data) && !cpumask_subset(affinity, cpu_online_mask)) this_count++; } -- 1.8.3.1
| |