| Subject | Re: [PATCH v3 01/21 resend] serial: rewrite pxa2xx-uart to use 8250_core | From | Sergei Ianovich <> | Date | Thu, 19 Dec 2013 13:35:13 +0400 |
| |
Hi Heikki,
On Thu, 2013-12-19 at 10:51 +0200, Heikki Krogerus wrote: > I noticed one more thing. I'm sorry about commenting this late. > > Since you set the type PORT_XSCALE, don's you want to use > UPF_FIXED_TYPE flag instead of the UPF_SKIP_TEST here? Otherwise the > type will just get overridden and autoconfig() will be executed.
UPF_FIXED_PORT was my first guess. However, it didn't work.
I've also tried to do ioremap in serial_pxa_probe instead of using UPF_IOREMAP. This didn't work as well.
I've left this
uart.port.type = PORT_XSCALE;
as an indicator that 8250_pxa depends on this port type, and anyone changing its specific code paths should test with 8250_pxa. This line could be safely removed or commented out, if you feel strongly about that.
> I'm guessing you also want to prevent things like the irq and the > uartclk from being changed by anybody by using the flag > UPF_FIXED_PORT, right?
IIRC, autoprobing doesn't change irq or uartclk.
|