Messages in this thread | | | Date | Wed, 18 Dec 2013 18:45:41 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] regmap: Allow regmap_bulk_write() to work for "no-bus" regmaps |
| |
On Mon, Dec 16, 2013 at 06:30:47PM -0800, Stephen Boyd wrote:
> - /* No formatting is require if val_byte is 1 */ > - if (val_bytes == 1) { > - wval = (void *)val; > + ival = *(unsigned int *)(val + (i * val_bytes)); > + ret = _regmap_write(map, reg + (i * map->reg_stride), > + ival); > + if (ret != 0) > + goto out;
This doesn't quite work - val is an array of objects of the size of the size of a register not of unsigned integers so you're parsing extra data out there. That possibly wasn't the best choice of API but we have quite a few users now so ick. [unhandled content-type:application/pgp-signature] | |