lkml.org 
[lkml]   [2013]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] regmap: Allow regmap_bulk_write() to work for "no-bus" regmaps
    On 12/18/13 10:45, Mark Brown wrote:
    > On Mon, Dec 16, 2013 at 06:30:47PM -0800, Stephen Boyd wrote:
    >
    >> - /* No formatting is require if val_byte is 1 */
    >> - if (val_bytes == 1) {
    >> - wval = (void *)val;
    >> + ival = *(unsigned int *)(val + (i * val_bytes));
    >> + ret = _regmap_write(map, reg + (i * map->reg_stride),
    >> + ival);
    >> + if (ret != 0)
    >> + goto out;
    > This doesn't quite work - val is an array of objects of the size of the
    > size of a register not of unsigned integers so you're parsing extra data
    > out there. That possibly wasn't the best choice of API but we have
    > quite a few users now so ick.

    Are you concerned that we'll read past the end of the val buffer? Do we
    need to cast the pointer to be the appropriate size according to
    val_bytes? Something like this?

    for (i = 0; i < val_count; i++) {
    unsigned int ival;

    switch (val_bytes) {
    case 1:
    ival = *(u8 *)(val + (i * val_bytes));
    break;
    case 2:
    ival = *(u16 *)(val + (i * val_bytes));
    break;
    case 4:
    ival = *(u32 *)(val + (i * val_bytes));
    break;
    #ifdef CONFIG_64BIT
    case 8:
    ival = *(u64 *)(val + (i * val_bytes));
    break;
    #endif
    default:
    ret = -EINVAL;
    goto out;
    }

    ret = _regmap_write(map, reg + (i * map->reg_stride),
    ival);
    if (ret != 0)
    goto out;
    }

    --
    Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
    hosted by The Linux Foundation



    \
     
     \ /
      Last update: 2013-12-23 21:41    [W:9.289 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site