lkml.org 
[lkml]   [2013]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 3/3] pci: Add Virtual Channel to save/restore support
On Tue, Dec 17, 2013 at 1:28 PM, Alex Williamson
<alex.williamson@redhat.com> wrote:
> On Tue, 2013-12-17 at 11:03 -0700, Bjorn Helgaas wrote:
>> On Tue, Dec 10, 2013 at 11:48:45AM -0700, Alex Williamson wrote:
>> >...
>> > + pci_read_config_dword(dev->bus->self, pos2 + PCI_VC_PORT_REG1, &reg1);
>> > + evcc = reg1 & PCI_VC_REG1_EVCC;
>>
>> I think PCI_VC_PORT_REG1 and PCI_VC_PORT_REG2 are mis-named and should be
>> changed to CAP1 and CAP2 or similar. Almost everything here is a
>> "register."
>
> That's true, but it matches the name in the spec: "Port VC Capability
> Register 1/2". Thanks,

Sure, but we use PCI_EXP_DEVCAP for the "Device Capabilities
Register," PCI_EXP_DEVCTL for the "Device Control Register," etc. All
I'm saying is that "REG" doesn't convey as much information as "CAP."

Bjorn


\
 
 \ /
  Last update: 2013-12-17 23:01    [W:0.058 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site