Messages in this thread | | | Subject | Re: [PATCH 3/3] pci: Add Virtual Channel to save/restore support | From | Alex Williamson <> | Date | Tue, 17 Dec 2013 13:28:57 -0700 |
| |
On Tue, 2013-12-17 at 11:03 -0700, Bjorn Helgaas wrote: > On Tue, Dec 10, 2013 at 11:48:45AM -0700, Alex Williamson wrote: > >... > > + pci_read_config_dword(dev->bus->self, pos2 + PCI_VC_PORT_REG1, ®1); > > + evcc = reg1 & PCI_VC_REG1_EVCC; > > I think PCI_VC_PORT_REG1 and PCI_VC_PORT_REG2 are mis-named and should be > changed to CAP1 and CAP2 or similar. Almost everything here is a > "register."
That's true, but it matches the name in the spec: "Port VC Capability Register 1/2". Thanks,
Alex
| |