lkml.org 
[lkml]   [2013]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/9] mtd: nand: davinci: fix driver registration
On 12/17/2013 11:24 AM, Brian Norris wrote:
> On Thu, Dec 05, 2013 at 07:25:49PM +0200, Ivan Khoronzhuk wrote:
>> --- a/drivers/mtd/nand/davinci_nand.c
>> +++ b/drivers/mtd/nand/davinci_nand.c
>> @@ -877,6 +877,7 @@ static int __exit nand_davinci_remove(struct platform_device *pdev)
>> }
>>
>> static struct platform_driver nand_davinci_driver = {
>> + .probe = nand_davinci_probe,
>> .remove = __exit_p(nand_davinci_remove),
>
> I believe you need to drop the __exit_p() here. And now that you're
> using module_platform_driver(), you need to drop the __init and __exit
> from the probe() and remove() routines, to avoid section mismatch
> warnings.
>
>> .driver = {
>> .name = "davinci_nand",
>
> So on second thought, please resubmit the series with the requested
> changes.
>
> Thanks,
> Brian
>

Thanks, Brian.
Do you want me to drop it in stand alone patch or in this one?

--
Regards,
Ivan Khoronzhuk


\
 
 \ /
  Last update: 2013-12-17 11:41    [W:0.162 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site