lkml.org 
[lkml]   [2013]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 01/03] clocksource: Add Kconfig entries for CMT, MTU2, TMU and STI
From
Hi Olof,

On Thu, Dec 12, 2013 at 10:05 AM, Olof Johansson <olof@lixom.net> wrote:
> Hi,
>
> A couple of small comments below.

Thanks for your feedback!

> On Thu, Dec 12, 2013 at 08:56:26AM +0900, Magnus Damm wrote:
>> From: Magnus Damm <damm@opensource.se>
>>
>> Add Kconfig entries for CMT, MTU2, TMU and STI to
>> drivers/clocksource/Kconfig. This will allow us to
>> get rid of duplicated entires in architecture code
>> such as arch/sh and arch/arm/mach-shmobile.
>>
>> Signed-off-by: Magnus Damm <damm@opensource.se>
>> ---
>>
>> drivers/clocksource/Kconfig | 44 +++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 44 insertions(+)
>>
>> --- 0001/drivers/clocksource/Kconfig
>> +++ work/drivers/clocksource/Kconfig 2013-12-12 08:41:55.000000000 +0900
>> @@ -134,3 +134,47 @@ config VF_PIT_TIMER
>> bool
>> help
>> Support for Period Interrupt Timer on Freescale Vybrid Family SoCs.
>> +
>> +config SYS_SUPPORTS_CMT
>> + bool
>> +
>> +config SYS_SUPPORTS_TMU
>> + bool
>> +
>> +config SYS_SUPPORTS_MTU2
>> + bool
>> +
>> +config SYS_SUPPORTS_STI
>> + bool
>
> Maybe a prefix to avoid namespace collissions here?

Sure, that is fine with me. I based the ones above on already existing
ones used by SH but I don't mind reworking those.

How about SYS_SUPPORTS_CLKSRC_xxx?

>> +config SH_TIMER_CMT
>> + bool "Renesas CMT timer driver" if COMPILE_TEST
>> + default SYS_SUPPORTS_CMT
>
> It might be useful to have an explicit depends on ARCH_SH || ARCH_SHMOBILE
> || COMPILE_TEST on these, just to make it easier for someone reading
> the code later on.

I have any strong feelings one way or the other about that myself, but
I got the impression that John Stultz preferred to not allow manual
selection at all, and my compromise here is to allow it only when
COMPILE_TEST is selected.

Would you be ok to keep it as-is for now? If needed then we can add an
incremental patch later to enable more flexible selection.

Thanks,

/ magnus


\
 
 \ /
  Last update: 2013-12-13 12:01    [W:0.091 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site