Messages in this thread | | | Date | Wed, 11 Dec 2013 17:05:03 -0800 | From | Olof Johansson <> | Subject | Re: [PATCH v4 01/03] clocksource: Add Kconfig entries for CMT, MTU2, TMU and STI |
| |
Hi,
A couple of small comments below.
On Thu, Dec 12, 2013 at 08:56:26AM +0900, Magnus Damm wrote: > From: Magnus Damm <damm@opensource.se> > > Add Kconfig entries for CMT, MTU2, TMU and STI to > drivers/clocksource/Kconfig. This will allow us to > get rid of duplicated entires in architecture code > such as arch/sh and arch/arm/mach-shmobile. > > Signed-off-by: Magnus Damm <damm@opensource.se> > --- > > drivers/clocksource/Kconfig | 44 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > --- 0001/drivers/clocksource/Kconfig > +++ work/drivers/clocksource/Kconfig 2013-12-12 08:41:55.000000000 +0900 > @@ -134,3 +134,47 @@ config VF_PIT_TIMER > bool > help > Support for Period Interrupt Timer on Freescale Vybrid Family SoCs. > + > +config SYS_SUPPORTS_CMT > + bool > + > +config SYS_SUPPORTS_TMU > + bool > + > +config SYS_SUPPORTS_MTU2 > + bool > + > +config SYS_SUPPORTS_STI > + bool
Maybe a prefix to avoid namespace collissions here?
> + > +config SH_TIMER_CMT > + bool "Renesas CMT timer driver" if COMPILE_TEST > + default SYS_SUPPORTS_CMT
It might be useful to have an explicit depends on ARCH_SH || ARCH_SHMOBILE || COMPILE_TEST on these, just to make it easier for someone reading the code later on.
-Olof
| |