Messages in this thread | | | Date | Wed, 11 Dec 2013 09:21:23 +0000 | From | Mel Gorman <> | Subject | Re: [PATCH v5 8/8] sched/numa: drop unnecessary variable in task_weight |
| |
On Wed, Dec 11, 2013 at 08:50:01AM +0800, Wanpeng Li wrote: > Drop unnecessary total_faults variable in function task_weight to unify > task_weight and group_weight. > > Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> > Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Nak.
task_weight is called for tasks other than current. If p handles a fault in parallel then it can drop to 0 between when it's checked and used to divide resulting in an oops.
-- Mel Gorman SUSE Labs
| |