lkml.org 
[lkml]   [2013]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 2/8] sched/numa: drop sysctl_numa_balancing_settle_count sysctl
    Date
    commit 887c290e (sched/numa: Decide whether to favour task or group weights
    based on swap candidate relationships) drop the check against
    sysctl_numa_balancing_settle_count, this patch remove the sysctl.

    Acked-by: Mel Gorman <mgorman@suse.de>
    Reviewed-by: Rik van Riel <riel@redhat.com>
    Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
    ---
    include/linux/sched/sysctl.h | 1 -
    kernel/sched/fair.c | 9 ---------
    kernel/sysctl.c | 7 -------
    3 files changed, 0 insertions(+), 17 deletions(-)

    diff --git a/include/linux/sched/sysctl.h b/include/linux/sched/sysctl.h
    index 41467f8..31e0193 100644
    --- a/include/linux/sched/sysctl.h
    +++ b/include/linux/sched/sysctl.h
    @@ -48,7 +48,6 @@ extern unsigned int sysctl_numa_balancing_scan_delay;
    extern unsigned int sysctl_numa_balancing_scan_period_min;
    extern unsigned int sysctl_numa_balancing_scan_period_max;
    extern unsigned int sysctl_numa_balancing_scan_size;
    -extern unsigned int sysctl_numa_balancing_settle_count;

    #ifdef CONFIG_SCHED_DEBUG
    extern unsigned int sysctl_sched_migration_cost;
    diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
    index 42bb745..57f28d0 100644
    --- a/kernel/sched/fair.c
    +++ b/kernel/sched/fair.c
    @@ -886,15 +886,6 @@ static unsigned int task_scan_max(struct task_struct *p)
    return max(smin, smax);
    }

    -/*
    - * Once a preferred node is selected the scheduler balancer will prefer moving
    - * a task to that node for sysctl_numa_balancing_settle_count number of PTE
    - * scans. This will give the process the chance to accumulate more faults on
    - * the preferred node but still allow the scheduler to move the task again if
    - * the nodes CPUs are overloaded.
    - */
    -unsigned int sysctl_numa_balancing_settle_count __read_mostly = 4;
    -
    static void account_numa_enqueue(struct rq *rq, struct task_struct *p)
    {
    rq->nr_numa_running += (p->numa_preferred_nid != -1);
    diff --git a/kernel/sysctl.c b/kernel/sysctl.c
    index 34a6047..c8da99f 100644
    --- a/kernel/sysctl.c
    +++ b/kernel/sysctl.c
    @@ -385,13 +385,6 @@ static struct ctl_table kern_table[] = {
    .proc_handler = proc_dointvec,
    },
    {
    - .procname = "numa_balancing_settle_count",
    - .data = &sysctl_numa_balancing_settle_count,
    - .maxlen = sizeof(unsigned int),
    - .mode = 0644,
    - .proc_handler = proc_dointvec,
    - },
    - {
    .procname = "numa_balancing_migrate_deferred",
    .data = &sysctl_numa_balancing_migrate_deferred,
    .maxlen = sizeof(unsigned int),
    --
    1.7.7.6


    \
     
     \ /
      Last update: 2013-12-11 02:21    [W:2.837 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site