lkml.org 
[lkml]   [2013]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v0 64/71] perf tools: Hit all build ids when Instruction Tracing
Date
From: Adrian Hunter <adrian.hunter@intel.com>

We need to include all buildids when a perf.data
file contains Instruction Tracing data because we
do not decode the trace for that purpose because
it would take too long.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
tools/perf/builtin-buildid-list.c | 9 +++++++++
tools/perf/builtin-inject.c | 8 ++++++++
tools/perf/builtin-record.c | 10 +++++++++-
3 files changed, 26 insertions(+), 1 deletion(-)

diff --git a/tools/perf/builtin-buildid-list.c b/tools/perf/builtin-buildid-list.c
index ed3873b..d694309 100644
--- a/tools/perf/builtin-buildid-list.c
+++ b/tools/perf/builtin-buildid-list.c
@@ -69,6 +69,15 @@ static int perf_session__list_build_ids(bool force, bool with_hits)
session = perf_session__new(&file, false, &build_id__mark_dso_hit_ops);
if (session == NULL)
return -1;
+
+ /*
+ * We take all buildids when the file contains Instruction Tracing data
+ * because we do not decode the trace because it would take too long.
+ */
+ if (!perf_data_file__is_pipe(&file) &&
+ perf_header__has_feat(&session->header, HEADER_ITRACE))
+ with_hits = false;
+
/*
* in pipe-mode, the only way to get the buildids is to parse
* the record stream. Buildids are stored as RECORD_HEADER_BUILD_ID
diff --git a/tools/perf/builtin-inject.c b/tools/perf/builtin-inject.c
index ce1f298..cafa6ab 100644
--- a/tools/perf/builtin-inject.c
+++ b/tools/perf/builtin-inject.c
@@ -26,6 +26,7 @@ struct perf_inject {
struct perf_tool tool;
bool build_ids;
bool sched_stat;
+ bool have_itrace;
const char *input_name;
int pipe_output,
output;
@@ -120,6 +121,8 @@ static s64 perf_event__repipe_itrace(struct perf_tool *tool,
tool);
int ret;

+ inject->have_itrace = true;
+
if (!inject->pipe_output) {
off_t offset;

@@ -544,6 +547,11 @@ static int __cmd_inject(struct perf_inject *inject)
ret = perf_session__process_events(session, &inject->tool);

if (!inject->pipe_output) {
+ if (inject->build_ids && inject->have_itrace) {
+ perf_header__set_feat(&session->header,
+ HEADER_BUILD_ID);
+ dsos__hit_all(session);
+ }
/*
* The instruction traces have been removed and replaced with
* synthesized hardware events, so clear the feature flag.
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index b35963f..d51fba6 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -341,8 +341,16 @@ static void perf_record__exit(int status, void *arg)
if (!file->is_pipe) {
rec->session->header.data_size += rec->bytes_written;

- if (!rec->no_buildid)
+ if (!rec->no_buildid) {
process_buildids(rec);
+ /*
+ * We take all buildids when the file contains
+ * Instruction Tracing data because we do not decode the
+ * trace because it would take too long.
+ */
+ if (perf_record_opts_itracing(&rec->opts))
+ dsos__hit_all(rec->session);
+ }
perf_session__write_header(rec->session, rec->evlist,
file->fd, true);
perf_session__delete(rec->session);
--
1.8.5.1


\
 
 \ /
  Last update: 2013-12-11 14:21    [W:0.558 / U:1.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site