[lkml]   [2013]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v0 54/71] perf script: Always allow fields 'addr' and 'cpu' for itrace
On 11/12/13 21:41, David Ahern wrote:
> On 12/11/13, 5:37 AM, Alexander Shishkin wrote:
>> From: Adrian Hunter <>
>> If a file contains Instruction Tracing data then always allow
>> fields 'addr' and 'cpu' to be selected as options for perf
>> script. This is necessary because Instruction Trace decoding
>> may synthesize events with that information.
> Why hardcode it? If it is present and the user opts for it then it will be
> printed. Why is the itrace check needed?

itrace synthesizes events, so the events do not exist until the decoding
starts, thus the validation prevents you from having 'addr' or 'cpu' even
though they will show up in events later.

 \ /
  Last update: 2013-12-12 14:01    [W:0.105 / U:4.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site