Messages in this thread Patch in this message | | | Date | Wed, 11 Dec 2013 19:29:18 +0800 | From | Younger Liu <> | Subject | [RESENT PATCH] logfs: Check for the return value after calling find_or_create_page() |
| |
From: Younger Liu <liuyiyang@hisense.com>
In get_mapping_page(), after calling find_or_create_page(), the return value should be checked.
This patch has been provided: http://www.spinics.net/lists/linux-fsdevel/msg66948.html but not been applied now.
Signed-off-by: Younger Liu <liuyiyang@hisense.com> Cc: Younger Liu <younger.liucn@gmail.com> Cc: Vyacheslav Dubeyko <slava@dubeyko.com> Reviewed-by: Prasad Joshi <prasadjoshi.linux@gmail.com> --- fs/logfs/segment.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/logfs/segment.c b/fs/logfs/segment.c index d448a77..7f9b096 100644 --- a/fs/logfs/segment.c +++ b/fs/logfs/segment.c @@ -62,7 +62,8 @@ static struct page *get_mapping_page(struct super_block *sb, pgoff_t index, page = read_cache_page(mapping, index, filler, sb); else { page = find_or_create_page(mapping, index, GFP_NOFS); - unlock_page(page); + if (page) + unlock_page(page); } return page; } -- 1.7.9.5
| |