Messages in this thread | | | From | Florian Fainelli <> | Subject | Re: [PATCH RFC] net: of_mdio: Scan PHYs which have device_type set to ethernet-phy | Date | Wed, 11 Dec 2013 07:15:54 +0000 |
| |
Le jeudi 14 novembre 2013, 15:05:56 Srinivas Kandagatla a écrit : > According to Documentation/devicetree/bindings/net/phy.txt device_type > property of PHY nodes is mandatory, which should be set to > "ethernet-phy". This patch adds check in scanning phys and only scans > node which have device-type set to "ethernet-phy".
Please CC netdev@vger.kernel.org as there might be networking folks not actively following devicetree-discuss.
> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com> > --- > drivers/of/of_mdio.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c > index d5a57a9..78c53c7 100644 > --- a/drivers/of/of_mdio.c > +++ b/drivers/of/of_mdio.c > @@ -57,6 +57,9 @@ int of_mdiobus_register(struct mii_bus *mdio, struct > device_node *np) > > /* Loop over the child nodes and register a phy_device for each one */ > for_each_available_child_of_node(np, child) { > + /* A PHY must have device_type set to "ethernet-phy" */ > + if (of_node_cmp(child->type, "ethernet-phy")) > + continue;
As already stated by Grant this will break quite a lot of platforms out there. Technically speaking, ePAPR v1.1 only specifies that "cpu" and "memory" nodes should have a "device_type" property for compatibility. Altough I do agree that it is nice to have a properly set "device_type", we can't always rely on that. -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |