Messages in this thread | | | Date | Mon, 02 Dec 2013 09:57:23 +0800 | From | Chris Ruehl <> | Subject | Re: [PATCH 2/3 v3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag |
| |
Hi
On Sunday, December 01, 2013 01:28 AM, Sergei Shtylyov wrote: > Hello. > > On 30-11-2013 7:51, Chris Ruehl wrote: > >> usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag > >> * init the sts flag to 0 (missed) >> * Set PORTCS_STS only if VUSB_HS_PHY_TYPE > 1 >> otherwise the register is ReadOnly >> * Set/Reset correct BIT(28)/BIT(29) for STS > >> Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk> > > The coding style is still wrong at places... > .. >> - hw_write(ci, OP_DEVLC, DEVLC_STS, sts); >> + if ( sts ) > > Remove spaces around 'sts', please. ... >> + portsc = (ioread32(ci->hw_bank.regmap[OP_PORTSC]) >> + & PORTSC_STS); > > No need for outer (). And it's preferred that an operator is left at the > end of a first line, not starts the continuation line. > > WBR, Sergei >
Sergei, Thanks, I will take care of and have a question about style
portsc = ioread32(ci->hw_bank.regmap[OP_PORTSC] & PORTSC_STS;
the line in the if/else alignment extent the 80char barrier and should be splitted in this case '&' is at 81 .. how serious I should follow this one?
portsc = ioread32(ci->hw_bank.regmap[OP_PORTSC] & PORTSC_STS;
I keep this mail private don't want make too much noise on the list.
regards Chris
| |