Messages in this thread | | | Date | Thu, 07 Nov 2013 19:13:57 -0500 (EST) | Subject | Re: [patch] net: make ndev->irq signed for error handling | From | David Miller <> |
| |
From: Dan Carpenter <dan.carpenter@oracle.com> Date: Thu, 7 Nov 2013 10:48:49 +0300
> There is a bug in cpsw_probe() where we do: > > ndev->irq = platform_get_irq(pdev, 0); > if (ndev->irq < 0) { > > The problem is that "ndev->irq" is unsigned so the error handling > doesn't work. I have changed it to a regular int. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Even though some simplifications have been suggested wrt. how this irq value is obtained in the one place where it is used, I am applying Dan's patch for now.
| |