Messages in this thread | | | Date | Thu, 7 Nov 2013 17:44:38 +0530 | From | Mugunthan V N <> | Subject | Re: [patch] net: make ndev->irq signed for error handling |
| |
On Thursday 07 November 2013 01:18 PM, Dan Carpenter wrote: > There is a bug in cpsw_probe() where we do: > > ndev->irq = platform_get_irq(pdev, 0); > if (ndev->irq < 0) { > > The problem is that "ndev->irq" is unsigned so the error handling > doesn't work. I have changed it to a regular int. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> ndev->irq is never used any where in the driver, I think its better to remove this part of code from probe. If every one is ok, I can send a patch to remove the code.
Regards Mugunthan V N
| |