lkml.org 
[lkml]   [2013]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] seccomp: not compatible with ARM OABI
From
Thanks!

Reviewed-By: Will Drewry <wad@chromium.org>

On Wed, Nov 6, 2013 at 5:31 PM, Kees Cook <keescook@chromium.org> wrote:
> Make sure that seccomp filter won't be built when ARM OABI is in use,
> since there is work needed to distinguish calling conventions. Until
> that is done (which is likely never since OABI is deprecated), make
> sure seccomp filter is unavailable in the OABI compat world.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> arch/Kconfig | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/Kconfig b/arch/Kconfig
> index af2cc6eabcc7..6eaca7d92399 100644
> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -331,12 +331,15 @@ config HAVE_ARCH_SECCOMP_FILTER
>
> config SECCOMP_FILTER
> def_bool y
> - depends on HAVE_ARCH_SECCOMP_FILTER && SECCOMP && NET
> + depends on HAVE_ARCH_SECCOMP_FILTER && SECCOMP && NET && !OABI_COMPAT
> help
> Enable tasks to build secure computing environments defined
> in terms of Berkeley Packet Filter programs which implement
> task-defined system call filtering polices.
>
> + Not available on ARM when built with OABI compatibility due to
> + lack of a sensible way to distinguish the calling conventions.
> +
> See Documentation/prctl/seccomp_filter.txt for details.
>
> config HAVE_CONTEXT_TRACKING
> --
> 1.7.9.5
>
>
> --
> Kees Cook
> Chrome OS Security


\
 
 \ /
  Last update: 2013-11-07 04:41    [W:0.038 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site