Messages in this thread | | | Date | Thu, 7 Nov 2013 09:26:45 -0800 | Subject | Re: [PATCH] seccomp: not compatible with ARM OABI | From | Kees Cook <> |
| |
On Thu, Nov 7, 2013 at 2:59 AM, James Hogan <james.hogan@imgtec.com> wrote: > Hi, > > On 06/11/13 23:31, Kees Cook wrote: >> diff --git a/arch/Kconfig b/arch/Kconfig >> index af2cc6eabcc7..6eaca7d92399 100644 >> --- a/arch/Kconfig >> +++ b/arch/Kconfig >> @@ -331,12 +331,15 @@ config HAVE_ARCH_SECCOMP_FILTER >> >> config SECCOMP_FILTER >> def_bool y >> - depends on HAVE_ARCH_SECCOMP_FILTER && SECCOMP && NET >> + depends on HAVE_ARCH_SECCOMP_FILTER && SECCOMP && NET && !OABI_COMPAT > > Isn't this the whole point of HAVE_ARCH_SECCOMP_FILTER? > > Just change the select in arch/arm/Kconfig to this: > > select HAVE_ARCH_SECCOMP_FILTER if !OABI_COMPAT
Oh! Yeah, that's a much cleaner way to handle it. I totally forgot that "select" could be conditional. I will respin it that way.
Thanks!
-Kees
-- Kees Cook Chrome OS Security
| |