Messages in this thread | | | Date | Mon, 04 Nov 2013 09:38:00 +0900 | From | Chanwoo Choi <> | Subject | Re: [PATCH 2/2] extcon: arizona: Fix race with microphone detection and removal |
| |
On 10/28/2013 01:19 AM, Charles Keepax wrote: > The microphone detection code is run as delayed work to provide > additional debounce, it is possible that the jack could have been > removed by the time we process the microphone detection. Turn this case > into a no op. > > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> > --- > > As Lee Jones took the first patch (extcon: arizona: Add > defines for microphone detection levels) of my series > yesterday through his tree I have based this patch on the > extcon tree without that change applied. > > Thanks, > Charles > > drivers/extcon/extcon-arizona.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c > index dac8ba0..9c20850 100644 > --- a/drivers/extcon/extcon-arizona.c > +++ b/drivers/extcon/extcon-arizona.c > @@ -773,6 +773,12 @@ static void arizona_micd_detect(struct work_struct *work) > > mutex_lock(&info->lock); > > + if (!info->cable) { > + dev_dbg(arizona->dev, "Ignoring MICDET for removed cable\n"); > + mutex_unlock(&info->lock); > + return; > + } > + > for (i = 0; i < 10 && !(val & 0x7fc); i++) { > ret = regmap_read(arizona->regmap, ARIZONA_MIC_DETECT_3, &val); > if (ret != 0) { >
This patch has build break as below log:
drivers/extcon/extcon-arizona.c: In function ‘arizona_micd_detect’: drivers/extcon/extcon-arizona.c:776:11: error: ‘struct arizona_extcon_info’ has no member named ‘cable’
The arizona_extcon_info structure hasn't included 'cable' field.
Cheers, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |