Messages in this thread | | | Date | Mon, 04 Nov 2013 18:41:41 +0900 | From | Chanwoo Choi <> | Subject | Re: [PATCH v2 1/2] extcon: arizona: Fix reset of HPDET after race with removal |
| |
On 11/04/2013 06:21 PM, Charles Keepax wrote: > On Mon, Nov 04, 2013 at 09:32:50AM +0900, Chanwoo Choi wrote: >> The arizona_hpdet_do_id() return only either -EAGIN or 0(zero). >> extcon-arizona driver could never execute 'goto done;' statement. >> >> ret = arizona_hpdet_do_id(info, &reading, &mic); >> if (ret == -EAGAIN) { >> goto out; >> } else if (ret < 0) { >> goto done; >> } > > True that else if is redundant at the moment, but personally I > would be inclined to leave it in, it feels safer against possible > future edits of arizona_hpdet_do_id. It would be reasonable for > someone to assume that other return values are acceptable whilst > editing it but they would then not be handled.
I know your intention. But, I cannot apply this patch for potential issue. Also, we have to fix below dead code after returning arizona_hpdet_do_id()
>> } else if (ret < 0) { >> goto done; >> }
Thanks, Chanwoo Choi
| |