Messages in this thread | | | Date | Fri, 29 Nov 2013 17:49:04 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH 1/1] usermodehelper: kill ____call_usermodehelper()->set_cpus_allowed_ptr() |
| |
Hi Tejun,
On 11/29, Tejun Heo wrote: > > Hey, Oleg. > > On Thu, Nov 28, 2013 at 08:33:49PM +0100, Oleg Nesterov wrote: > > @@ -208,13 +208,9 @@ static int ____call_usermodehelper(void *data) > > spin_lock_irq(¤t->sighand->siglock); > > flush_signal_handlers(current, 1); > > spin_unlock_irq(¤t->sighand->siglock); > > - > > - /* We can run anywhere, unlike our parent keventd(). */ > > - set_cpus_allowed_ptr(current, cpu_all_mask); > > I don't think this is correct on numa machines where unbound workers > are NUMA-node affine by default.
Aaah, I see. And you even mentioned this before, but I didn't pay attention.
Thank!
Oleg.
| |