lkml.org 
[lkml]   [2013]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] usermodehelper: kill ____call_usermodehelper()->set_cpus_allowed_ptr()
Hey, Oleg.

On Thu, Nov 28, 2013 at 08:33:49PM +0100, Oleg Nesterov wrote:
> @@ -208,13 +208,9 @@ static int ____call_usermodehelper(void *data)
> spin_lock_irq(&current->sighand->siglock);
> flush_signal_handlers(current, 1);
> spin_unlock_irq(&current->sighand->siglock);
> -
> - /* We can run anywhere, unlike our parent keventd(). */
> - set_cpus_allowed_ptr(current, cpu_all_mask);

I don't think this is correct on numa machines where unbound workers
are NUMA-node affine by default.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2013-11-29 15:01    [W:0.198 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site