lkml.org 
[lkml]   [2013]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] dmaengine: pl08x: fix conversioin for generic unmap data
From
On Tue, Nov 26, 2013 at 8:53 PM, Olof Johansson <olof@lixom.net> wrote:
> commit d38a8c622a1b ('dmaengine: prepare for generic 'unmap' data')
> added a generic unmap call but used the wrong argument for it. Fix it.
>
> Fixes: d38a8c622a1b ('dmaengine: prepare for generic 'unmap' data')
> Signed-off-by: Olof Johansson <olof@lixom.net>
> ---
>
> I can't actually tell what the intent of d38a8cc622a1b and how mappings
> are expected to be managed, but it's obviously passing the wrong thing
> in here so it seems like the appropriate fix.
>

For most dma-slave usage cases the client is explicitly handling the
lifetime of the dma mappings. It's primarily the mem-to-mem usage
cases that rely on the dma driver to do the unmapping when the
transaction is complete. dma_descriptor_unmap() is a common
implementation rather than requiring each driver to implement it
uniquely. Longer term we can require all clients to handle their
mapping lifetimes and remove the responsibility from the individual
drivers completely.


\
 
 \ /
  Last update: 2013-11-27 21:01    [W:0.052 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site