lkml.org 
[lkml]   [2013]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] dmaengine: pl08x: fix conversioin for generic unmap data
    On Tue, Nov 26, 2013 at 08:53:24PM -0800, Olof Johansson wrote:
    > commit d38a8c622a1b ('dmaengine: prepare for generic 'unmap' data')
    > added a generic unmap call but used the wrong argument for it. Fix it.
    >
    > Fixes: d38a8c622a1b ('dmaengine: prepare for generic 'unmap' data')
    > Signed-off-by: Olof Johansson <olof@lixom.net>
    Acked-by: Vinod Koul <vinod.koul@Intel.com>

    > ---
    >
    > I can't actually tell what the intent of d38a8cc622a1b and how mappings
    > are expected to be managed, but it's obviously passing the wrong thing
    > in here so it seems like the appropriate fix.
    >
    > drivers/dma/amba-pl08x.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
    > index 16a2aa28f856..ec4ee5c1fe9d 100644
    > --- a/drivers/dma/amba-pl08x.c
    > +++ b/drivers/dma/amba-pl08x.c
    > @@ -1169,7 +1169,7 @@ static void pl08x_desc_free(struct virt_dma_desc *vd)
    > struct pl08x_txd *txd = to_pl08x_txd(&vd->tx);
    > struct pl08x_dma_chan *plchan = to_pl08x_chan(vd->tx.chan);
    >
    > - dma_descriptor_unmap(txd);
    > + dma_descriptor_unmap(&vd->tx);
    > if (!txd->done)
    > pl08x_release_mux(plchan);
    >
    > --
    > 1.8.4.1.601.g02b3b1d
    >

    --


    \
     
     \ /
      Last update: 2013-11-28 08:41    [W:2.603 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site