Messages in this thread | | | Date | Wed, 27 Nov 2013 16:53:54 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 2/2] regulator: core: Check for DT every time we check full constraints |
| |
On Wed, Nov 27, 2013 at 04:32:59PM +0000, Jon Medhurst (Tixy) wrote:
> Doesn't this now make this code in regulator_init_complete() > redundant..?
> if (of_have_populated_dt()) > has_full_constraints = true;
Yes, it is a bit redundant now.
> Or is keeping this to avoid one less variable check a worthwhile > optimisation?
I expect it can be removed, I just wanted to check that the function wasn't horribly expensive for some silly reason before I actually went and did that. [unhandled content-type:application/pgp-signature] | |