lkml.org 
[lkml]   [2013]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/5] perf diff: generalize hpp__color_delta for -c
On Sun, Nov 24, 2013 at 11:50:23AM +0530, Ramkumar Ramachandra wrote:

SNIP

> container_of(fmt, struct diff_hpp_fmt, fmt);
> struct hist_entry *pair = get_pair_fmt(he, dfmt);
> - double percent;
> + double delta;
> char pfmt[20] = " ";
>
> if (!pair)
> goto dummy_print;
> if (pair->diff.computed)
> - percent = pair->diff.period_ratio_delta;
> + switch (comparison_method) {
> + case COMPUTE_DELTA:
> + delta = pair->diff.period_ratio_delta;
> + break;
> + default:
> + BUG_ON(1);
> + }
> else
> - percent = compute_delta(he, pair);
> + switch (comparison_method) {
> + case COMPUTE_DELTA:
> + delta = compute_delta(he, pair);
> + break;
> + default:
> + BUG_ON(1);
> + }
>
> - if (!he->dummy && fabs(percent) >= 0.01) {
> - scnprintf(pfmt, 20, "%%%+d.2f%%%%", dfmt->header_width - 1);
> - return color_snprintf(hpp->buf, hpp->size,
> - percent > 0 ? PERF_COLOR_GREEN : PERF_COLOR_RED,
> - pfmt, percent);
> + if (!he->dummy) {
> + switch (comparison_method) {
> + case COMPUTE_DELTA:
> + if (fabs(delta) < 0.01)
> + goto dummy_print;
> + scnprintf(pfmt, 20, "%%%+d.2f%%%%", dfmt->header_width - 1);
> + return color_snprintf(hpp->buf, hpp->size,
> + delta > 0 ? PERF_COLOR_GREEN : PERF_COLOR_RED,
> + pfmt, delta);
> + break;

I think it'd be better to have just one switch for
comparison_method and do all the processing within

thanks,
jirka


\
 
 \ /
  Last update: 2013-11-26 13:41    [W:0.600 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site