Messages in this thread | | | Date | Tue, 26 Nov 2013 12:32:51 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH v2 1/5] perf diff: don't compute Delta if he->dummy |
| |
On Sun, Nov 24, 2013 at 11:50:21AM +0530, Ramkumar Ramachandra wrote: > Cc: Arnaldo Carvalho de Melo <acme@redhat.com> > Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> > --- > tools/perf/builtin-diff.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c > index 3b67ea2..79e0448 100644 > --- a/tools/perf/builtin-diff.c > +++ b/tools/perf/builtin-diff.c > @@ -792,6 +792,9 @@ hpp__entry_pair(struct hist_entry *he, struct hist_entry *pair, > > switch (idx) { > case PERF_HPP_DIFF__DELTA: > + if (he->dummy) > + break; > +
the reason I disabled the computation for dummy pairs was that the number (ratio and weighted diff) would not make much sense (to me) without the real pair
but within the dummy delta column we actually see the compared file % overheader which is helpfull, even if there's no real pair in the baseline
jirka
| |