Messages in this thread |  | | Date | Mon, 25 Nov 2013 17:26:20 +0530 | From | Sekhar Nori <> | Subject | Re: [PATCH 1/6] watchdog: davinci: change driver to use WDT core |
| |
On Monday 18 November 2013 10:48 PM, Ivan Khoronzhuk wrote: > @@ -211,29 +129,34 @@ static int davinci_wdt_probe(struct platform_device *pdev) > > clk_prepare_enable(wdt_clk); > > - if (heartbeat < 1 || heartbeat > MAX_HEARTBEAT) > - heartbeat = DEFAULT_HEARTBEAT; > + wdd = &wdt_wdd; > + wdd->info = &davinci_wdt_info; > + wdd->ops = &davinci_wdt_ops; > + wdd->min_timeout = 1; > + wdd->max_timeout = MAX_HEARTBEAT;
Some checkpatch warnings. Please fix.
WARNING: please, no space before tabs #273: FILE: drivers/watchdog/davinci_wdt.c:135: +^Iwdd->min_timeout ^I= 1;$
WARNING: please, no space before tabs #274: FILE: drivers/watchdog/davinci_wdt.c:136: +^Iwdd->max_timeout ^I= MAX_HEARTBEAT;$
total: 0 errors, 2 warnings, 0 checks, 249 lines checked
Thanks, sekhar
|  |