Messages in this thread Patch in this message | | | From | Elena Ufimtseva <> | Subject | [PATCH v2] checkpatch.pl: Check for functions without a real prototype | Date | Fri, 22 Nov 2013 17:17:44 -0500 |
| |
Based on Richard Weinberger patch https://lkml.org/lkml/2012/3/16/510 Functions like this one are evil:
void foo() { ... }
Signed-off-by: Elena Ufimtseva <ufimtseva@gmail.com> --- Changes since v1: - added white space in regular expression between (), based on comments from Joe Perches.
scripts/checkpatch.pl | 13 +++++++++++++ 1 file changed, 13 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 61090e0..08c95c0 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2785,6 +2785,19 @@ sub process { "open brace '{' following function declarations go on the next line\n" . $herecurr); } + if ($line =~ /(\b$Type\s+$Ident)\s*\(\s*\)/) { + ERROR("FUNCTION_NO_PROTOTYPE", +"Bad function definition - $1() should probably be $1(void)\n" . $herecurr . +"\nThou shalt not, in the language of C, under any circumstances, on the +pain of death, declare or define a function with an empty set of +parentheses, for though in the language of C++ it meaneth the same as +(void), in C it meaneth (...) which is of meaningless as there be no +anchor argument by which the types of the varadic arguments can be +expressed, and which misleadeth the compiler into allowing unsavory code +and in some cases generate really ugly stuff for varadic handling. + -hpa\n"); + } + # open braces for enum, union and struct go on the same line. if ($line =~ /^.\s*{/ && $prevline =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?\s*$/) { -- 1.7.10.4
| |