Messages in this thread | | | Date | Sun, 17 Nov 2013 19:09:07 -0200 | Subject | Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code | From | Geyslan Gregório Bem <> |
| |
2013/11/17 James Bottomley <James.Bottomley@hansenpartnership.com>: > On Sun, 2013-11-17 at 15:51 -0300, Geyslan G. Bem wrote: >> This patch fix memory leakage in cases 'ISCSI_NET_PARAM_VLAN_ID' and >> 'ISCSI_NET_PARAM_VLAN_PRIORITY' and refactors code 'going out' when >> necessary. > > You pointlessly renamed a variable, which makes the diff hard to read. > Please don't do that.
Ok, I can agree. 'len' means length? What is returned in case of non error?
> > You missed the fact that the passed in pointer is unmodified if > mgmt_get_if_info() returns non zero, so the kfree frees junk and would > oops. > > There's no need for a goto; len = -EINVAL; does everything that's > needed.
Well, that is a coverity catch. CID 1128954. Check it.
> > James > >
Thanks.
-- Regards,
Geyslan G. Bem hackingbits.com
| |