Messages in this thread | | | Subject | Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code | From | James Bottomley <> | Date | Sun, 17 Nov 2013 11:42:51 -0800 |
| |
On Sun, 2013-11-17 at 15:51 -0300, Geyslan G. Bem wrote: > This patch fix memory leakage in cases 'ISCSI_NET_PARAM_VLAN_ID' and > 'ISCSI_NET_PARAM_VLAN_PRIORITY' and refactors code 'going out' when > necessary.
You pointlessly renamed a variable, which makes the diff hard to read. Please don't do that.
You missed the fact that the passed in pointer is unmodified if mgmt_get_if_info() returns non zero, so the kfree frees junk and would oops.
There's no need for a goto; len = -EINVAL; does everything that's needed.
James
| |