Messages in this thread | | | Date | Mon, 11 Nov 2013 15:12:12 +0100 | From | Michal Marek <> | Subject | Re: [kallsyms] general protection fault: 0000 [#1] PREEMPT DEBUG_PAGEALLOC |
| |
On 11.11.2013 14:27, Joe Mario wrote: > On 11/11/2013 07:07 AM, Michal Marek wrote: >> I'm testing a patch for include/linux/pci.h to use line numbers >> instead of the PCI ID macros to declare the __pci_fixup_* symbols. >> If that works, we can revert the limit back to 128 and only keep >> the check in kallsyms.c. >> >> Michal > > Michal: That would be great.
I just posted the patches.
> I found six locations which were still using an array size hardwired > to "128" instead of KSYM_NAME_LEN. But none of them were related to > the crash Fengguang Wu reported. We built a 32-bit kernel from his > config (with a few issues) but were unable to reproduce the crash. > Still trying.
I also did not manage to reproduce it, but then I didn't try too hard.
> Whatever happens, I agree the check in kallsyms.c for kernel symbols > whose length exceeds the buffer size, needs to be in place.
I plan to merge "[PATCH 2/2] kallsyms: Revert back to 128 max symbol length" to kbuild.git ASAP, even if "[PATCH 1/2] PCI: Do not use PCI ID macros in quirk names" is merged later.
Michal
| |