lkml.org 
[lkml]   [2013]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [kallsyms] general protection fault: 0000 [#1] PREEMPT DEBUG_PAGEALLOC
On 10.11.2013 16:23, Andi Kleen wrote:
> On Sun, Nov 10, 2013 at 05:40:05PM +0800, Fengguang Wu wrote:
>> Hi Joe,
>>
>> FYI. Here is another bisect result.
>
> I bet it's that strncpy() in kallsyms.c and someone passing in a too
> short buffer on a 32bit kernel.
>
> We should really kill strncpy(), it's just evil.

I'm testing a patch for include/linux/pci.h to use line numbers instead
of the PCI ID macros to declare the __pci_fixup_* symbols. If that
works, we can revert the limit back to 128 and only keep the check in
kallsyms.c.

Michal


\
 
 \ /
  Last update: 2013-11-11 13:21    [W:0.053 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site