lkml.org 
[lkml]   [2013]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] trace-cmd: use pkg-config instead of python-config
Please Cc me on trace-cmd patches.

Johannes and Darren,

Since you handle the python bindings in trace-cmd, can you give me an
ack or nack.

Thanks!

-- Steve


On Thu, 31 Oct 2013 18:39:42 +0100
Romain Naour <romain.naour@openwide.fr> wrote:

> From: Romain <romain.naour@openwide.fr>
>
> trace-cmd use python-config to find out which headers
> and libraries should be used to link against the Python libraries.
> By default, python-config returns paths that are inappropriate for
> cross-compilation.
>
> Add PYTHON_VERS to build trace-cmd with python2 or python3
>
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> Makefile | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 1964949..2f862ec 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -81,8 +81,10 @@ ifndef NO_PYTHON
> PYTHON := ctracecmd.so
> PYTHON_GUI := ctracecmd.so ctracecmdgui.so
>
> +PYTHON_VERS ?= python
> +
> # Can build python?
> -ifeq ($(shell sh -c "python-config --includes > /dev/null 2>&1 && echo y"), y)
> +ifeq ($(shell sh -c "pkg-config --cflags $(PYTHON_VERS) > /dev/null 2>&1 && echo y"), y)
> PYTHON_PLUGINS := plugin_python.so
> BUILD_PYTHON := $(PYTHON) $(PYTHON_PLUGINS)
> PYTHON_SO_INSTALL := ctracecmd.install
> @@ -550,8 +552,8 @@ clean:
>
> ##### PYTHON STUFF #####
>
> -PYTHON_INCLUDES = `python-config --includes`
> -PYTHON_LDFLAGS = `python-config --ldflags` \
> +PYTHON_INCLUDES = `pkg-config --cflags $(PYTHON_VERS)`
> +PYTHON_LDFLAGS = `pkg-config --libs $(PYTHON_VERS)` \
> $(shell python -c "import distutils.sysconfig; print distutils.sysconfig.get_config_var('LINKFORSHARED')")
> PYGTK_CFLAGS = `pkg-config --cflags pygtk-2.0`
>



\
 
 \ /
  Last update: 2013-11-01 22:41    [W:0.849 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site