Messages in this thread | | | Date | Mon, 4 Nov 2013 14:20:05 -0800 | Subject | Re: [PATCH 1/1] trace-cmd: use pkg-config instead of python-config | From | Darren Hart <> |
| |
I'm hardly an expert here, but the appears sane to me. Perhaps a comment above the PYTHON_VERS describing what valid values are would be helpful. Otherwise, looks good to me.
On Mon, Nov 4, 2013 at 12:32 AM, Johannes Berg <johannes@sipsolutions.net> wrote: > On Fri, 2013-11-01 at 17:19 -0400, Steven Rostedt wrote: >> Please Cc me on trace-cmd patches. >> >> Johannes and Darren, >> >> Since you handle the python bindings in trace-cmd, can you give me an >> ack or nack. > > Looks fine to me, in that it would work on my system :) > > johannes >
-- Darren Hart
| |