lkml.org 
[lkml]   [2013]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] arm64: add PAGE_ALIGNED_DATA to linker script
On Fri, Nov 01, 2013 at 03:01:30PM +0000, Mark Salter wrote:
> On Fri, 2013-10-11 at 08:18 -0400, Mark Salter wrote:
> > On Wed, 2013-10-09 at 11:14 +0100, Will Deacon wrote:
> > > > @@ -110,6 +110,7 @@ SECTIONS
> > > > */
> > > > INIT_TASK_DATA(THREAD_SIZE)
> > > > NOSAVE_DATA
> > > > + PAGE_ALIGNED_DATA(PAGE_SIZE)
> > > > CACHELINE_ALIGNED_DATA(64)
> > > > READ_MOSTLY_DATA(64)
> > >
> > > Can we just replace this chunk with RW_DATA_SECTION(64, PAGE_SIZE,
> > > THREAD_SIZE) instead?
> > >
> >
> > I took a look at this. It can be done, but the RW_DATA_SECTION aligns
> > data to PAGE_SIZE where the existing alignment is THREAD_SIZE. So using
> > RW_DATA_SECTION would waste some space if using 64K pagesize.
> >
> > --Mark
>
> So where do we stand with this one?

I'd probably go for using the generic macro, but I don't have strong
preferences either way.

Will


\
 
 \ /
  Last update: 2013-11-01 18:01    [W:0.077 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site