Messages in this thread Patch in this message |  | | Date | Fri, 1 Nov 2013 16:17:53 +0000 | From | Will Deacon <> | Subject | Re: [PATCH] arm64: add PAGE_ALIGNED_DATA to linker script |
| |
On Fri, Nov 01, 2013 at 03:01:30PM +0000, Mark Salter wrote: > On Fri, 2013-10-11 at 08:18 -0400, Mark Salter wrote: > > On Wed, 2013-10-09 at 11:14 +0100, Will Deacon wrote: > > > > @@ -110,6 +110,7 @@ SECTIONS > > > > */ > > > > INIT_TASK_DATA(THREAD_SIZE) > > > > NOSAVE_DATA > > > > + PAGE_ALIGNED_DATA(PAGE_SIZE) > > > > CACHELINE_ALIGNED_DATA(64) > > > > READ_MOSTLY_DATA(64) > > > > > > Can we just replace this chunk with RW_DATA_SECTION(64, PAGE_SIZE, > > > THREAD_SIZE) instead? > > > > > > > I took a look at this. It can be done, but the RW_DATA_SECTION aligns > > data to PAGE_SIZE where the existing alignment is THREAD_SIZE. So using > > RW_DATA_SECTION would waste some space if using 64K pagesize. > > > > --Mark > > So where do we stand with this one?
I'd probably go for using the generic macro, but I don't have strong preferences either way.
Will
|  |