Messages in this thread | | | Date | Mon, 4 Nov 2013 11:28:40 +0000 | From | Catalin Marinas <> | Subject | Re: [PATCH] arm64: add PAGE_ALIGNED_DATA to linker script |
| |
On Fri, Oct 11, 2013 at 01:18:41PM +0100, Mark Salter wrote: > On Wed, 2013-10-09 at 11:14 +0100, Will Deacon wrote: > > > @@ -110,6 +110,7 @@ SECTIONS > > > */ > > > INIT_TASK_DATA(THREAD_SIZE) > > > NOSAVE_DATA > > > + PAGE_ALIGNED_DATA(PAGE_SIZE) > > > CACHELINE_ALIGNED_DATA(64) > > > READ_MOSTLY_DATA(64) > > > > Can we just replace this chunk with RW_DATA_SECTION(64, PAGE_SIZE, > > THREAD_SIZE) instead? > > > > I took a look at this. It can be done, but the RW_DATA_SECTION aligns > data to PAGE_SIZE where the existing alignment is THREAD_SIZE. So using > RW_DATA_SECTION would waste some space if using 64K pagesize.
I think that's ok, especially since we may get security patches in the future to create more restrictive page table attributes (well, with the drawback of more TLB pressure). So I'm for more cleanup in the vmlinux file by using the generic defines.
-- Catalin
| |