lkml.org 
[lkml]   [2013]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 tip/core/rcu 0/13] Sparse-related updates for 3.13
On Wed, Oct 09, 2013 at 03:18:05PM -0700, Josh Triplett wrote:
> On Wed, Oct 09, 2013 at 02:29:20PM -0700, Paul E. McKenney wrote:
> > Hello!
> >
> > This series features updates to allow sparse to do a better job of
> > statically analyzing RCU usage:
> >
> > 1. Apply ACCESS_ONCE() to rcu_assign_pointer()'s target to prevent
> > comiler mischief. Also require that the source pointer be from
> > the kernel address space. Sometimes it can be from the RCU address
> > space, which necessitates the remaining patches in this series.
> > Which, it must be admitted, apply to a very small fraction of
> > the rcu_assign_pointer() invocations in the kernel. This commit
> > courtesy of Josh Triplett.
> >
> > 2-13. Apply rcu_access_pointer() to avoid a number of false positives.
>
> I would suggest moving patch 1 to the end of the series, to avoid
> introducing and subsequently fixing warnings.

That would help with bisectability, will do!

Thanx, Paul



\
 
 \ /
  Last update: 2013-10-10 01:01    [W:0.962 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site