Messages in this thread | | | Date | Mon, 7 Oct 2013 15:42:40 +0200 | Subject | Re: [PATCH v8] dmaengine: Add MOXA ART DMA engine driver | From | Jonas Jensen <> |
| |
Hi Mark,
Thanks for the replies. Please have a look at v9.
On 7 August 2013 17:13, Mark Rutland <mark.rutland@arm.com> wrote: >> + >> + ret = devm_request_irq(dev, irq, moxart_dma_interrupt, 0, >> + "moxart-dma-engine", mdc); >> + if (ret) { >> + dev_err(dev, "devm_request_irq failed\n"); > > Do you not need calls to of_dma_controller_free and > dma_async_device_unregister here? I'm not all that familiar with the DMA > API, so maybe you don't.
Yes. I see now, I should have moved both dma_async_device_register() and of_dma_controller_register() to happen after devm_request_irq(). I'll include that in next version.
>> +static int moxart_remove(struct platform_device *pdev) >> +{ >> + struct moxart_dma_container *m = dev_get_drvdata(&pdev->dev); > > Similarly, do you not need to call of_dma_controller free here?
Yes, this is now done.
Best regards, Jonas
| |