[lkml]   [2013]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v10] dmaengine: Add MOXA ART DMA engine driver
On 7 October 2013 17:12, Mark Rutland <> wrote:
> Sorry I didn't notice this previously, but "moxa" isn't in
> Documentation/devicetree/bindings/vendor-prefixes.txt (despite several
> bindings using it). Could you cook up a separate patch to add an entry
> for Moxa, please?

Yes, I'll submit a separate patch.

> Also, given the SoC is called "ART" it's a shame that we're calling this
> "moxa,moxart-dma" rather than "moxa,art-dma". We already have precedent
> for "moxart" in bindings though, so changing that's likely to lead to
> more problems.

Sorry about that, I think the "moxart" contraction was suggested and
has been sticky ever since.

It's at least a little appropriate because the physical chip text
reads "MOXA ART" (photo):

Currently three drivers in linux-next use the name with accompanying
device tree bindings.
Considering the amount of patches required, can we keep the name, please?

> Sorry for yet more pendantry, but could we instead have:
> - interrupts: Should contain an interrupt-specifier for the sole
> interrupt generated by the device.

Fixed in v11.


 \ /
  Last update: 2013-10-08 12:01    [W:0.157 / U:5.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site