Messages in this thread | | | Date | Tue, 29 Oct 2013 02:06:08 +0100 | From | Sebastian Reichel <> | Subject | Re: [PATCHv2 1/3] Input: twl4030-keypad - add device tree support |
| |
On Mon, Oct 28, 2013 at 01:42:47AM -0500, Kumar Gala wrote: > > +This binding is based on the matrix-keymap binding with the following > > +changes: > > Maybe be a bit more specific and say 'based on the input/matrix-keymap.txt binding'..
OK.
> > + * keypad,num-rows and keypad,num-columns are required. > > Is linux,keymap required from matrix-keymap.txt?
Yes, matrix-keymap.txt contains descriptions for the following:
required: - linux,keymap optional: - keypad,num-rows - keypad,num-columns
> > +Optional Properties specific to linux: > > +- linux,keypad-no-autorepeat: do no enable autorepeat feature. > > Does it make sense to update the matrix-keymap.txt binding to add > 'linux,keypad-no-autorepeat' there?
At least according to devicetree documentation there are keymap-matrix.txt based drivers, which do not support "linux,keypad-no-autorepeat".
-- Sebastian [unhandled content-type:application/pgp-signature] | |