Messages in this thread | | | From | Grant Likely <> | Subject | Re: [PATCHv2 1/3] Input: twl4030-keypad - add device tree support | Date | Wed, 30 Oct 2013 06:53:07 -0700 |
| |
On Sun, 27 Oct 2013 12:47:53 +0100, Pavel Machek <pavel@ucw.cz> wrote: > > > > +#if IS_ENABLED(CONFIG_OF) > > > I'm probably missing something here, but why not #ifdef CONFIG_OF? > > > > I have been told for other drivers, that IS_ENABLED() is > > the prefered way to check for configuration these days. > > CONFIG_OF can not be module, using IS_ENABLED() on it is just wrong.
That makes no sense. There is absolutely nothing wrong with using IS_ENABLED() for CONFIG_OF.
g.
| |