Messages in this thread | | | Date | Mon, 14 Oct 2013 20:45:48 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 4/5] uprobes: Change uprobe_copy_process() to dup return_instances |
| |
On Sun, Oct 13, 2013 at 09:18:41PM +0200, Oleg Nesterov wrote: > uprobe_copy_process() assumes that the new child doesn't need > ->utask, it should be allocated by demand. > > But this is not true if the forking task has the pending ret- > probes, the child should report them as well and thus it needs > the copy of parent's ->return_instances chain. Otherwise the > child crashes when it returns from the probed function.
So children don't automagically inherit the same probes (only though the high level interface -- like perf), so wouldn't simply fixing up the child stack be a solution?
If not; its not entirely clear to my why this isn't a good solution based on these changelogs.
| |