Messages in this thread | | | Date | Mon, 14 Oct 2013 20:29:03 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 0/5] uprobes: fix fork() with the pending ret-probe(s) |
| |
On 10/13, Oleg Nesterov wrote: > > Please review, this series fixes the serious bug reported by > Martin and David and cc's stable. See the changelog in 5/5.
Forgot to mention...
This probably needs another patch to handle the special case, vfork(). In this case it would be more correct to dup return_instances but (obviously) avoid dup_xol_area.
However I think this is not that important, the child should not "unwind" the stack if it shares mm/stack with its parent, otherwise it can corrupt the parent's stack.
So I think that this change (which needs to pass "clone_flags" to uprobe_copy_process) is not the stable material. But I'll update the changelog in 4/5 to explain that "mm == t->mm" check should be updated.
Oleg.
| |