Messages in this thread | | | Date | Mon, 14 Oct 2013 12:21:16 -0600 | From | Stephen Warren <> | Subject | Re: [Patch V5] drivers: power: Add support for bq24735 charger |
| |
On 10/11/2013 03:15 PM, Rhyland Klein wrote: > From: Darbha Sriharsha <dsriharsha@nvidia.com> > > Adds support for the bq24735 charger chipset. The bq24735 is a > high-efficiency, synchronous battery charger. > > It allows control of the charging current, input current, and the charger > voltage DAC's through SMBus.
Please CC the DT bindings maintainers on patches that add DT bindings.
> diff --git a/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt b/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt
> +Optional properties :
> + - ti,ac-detect-gpios : This GPIO is optionally used to read the AC adapter > + presence.
Is that actually a property of the BQ24735 chip itself (i.e. is it an output signal from the chip), or part of the board/system?
Aside from that, the binding looks reasonable to me (although I'm no longer a DT bindings maintainer).
| |